[PATCH] Implement IXMLDOMAttribute name property

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Sat Feb 16 05:31:01 CST 2008


---
 dlls/msxml3/attribute.c    |    5 +++--
 dlls/msxml3/tests/domdoc.c |   12 ++++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/dlls/msxml3/attribute.c b/dlls/msxml3/attribute.c
index 6ce969d..fef0f2a 100644
--- a/dlls/msxml3/attribute.c
+++ b/dlls/msxml3/attribute.c
@@ -470,8 +470,9 @@ static HRESULT WINAPI domattr_get_name(
     IXMLDOMAttribute *iface,
     BSTR *p)
 {
-    FIXME("\n");
-    return E_NOTIMPL;
+    /* name property returns the same value as nodeName */
+    domattr *This = impl_from_IXMLDOMAttribute( iface );
+    return IXMLDOMNode_get_nodeName( This->node, p );
 }
 
 static HRESULT WINAPI domattr_get_value(
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 9da1c94..182b324 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -2127,6 +2127,18 @@ static void test_xmlTypes(void)
                     ok(hr == S_OK, "ret %08x\n", hr );
                     ok( !lstrcmpW( str, _bstr_("attribute") ), "incorrect nodeTypeString string\n");
                     SysFreeString(str);
+                    
+                    /* test nodeName */
+                    hr = IXMLDOMAttribute_get_nodeName(pAttrubute, &str);
+                    ok(hr == S_OK, "ret %08x\n", hr );
+                    ok( !lstrcmpW( str, szAttribute ), "incorrect nodeName string\n");
+                    SysFreeString(str);
+                    
+                    /* test name property */
+                    hr = IXMLDOMAttribute_get_name(pAttrubute, &str);
+                    ok(hr == S_OK, "ret %08x\n", hr );
+                    ok( !lstrcmpW( str, szAttribute ), "incorrect name string\n");
+                    SysFreeString(str);
 
                     hr = IXMLDOMAttribute_get_xml(pAttrubute, &str);
                     ok(hr == S_OK, "ret %08x\n", hr );
-- 
1.5.3.8


--------------080203060503010506090206--




More information about the wine-patches mailing list