kernel32 & winex11: WaitForMultipleObjectsEx should ignore NULL handles

Adam Strzelecki ono at java.pl
Fri Feb 29 09:28:14 CST 2008


Hi,

In MSI dialog.c: msi_dialog_check_messages function it often happens  
that is sends:
MsgWaitForMultipleObjects( 1, &handle, 0, INFINITE, QS_ALLINPUT );
Where handle = NULL. I'm not sure if it is correct behavior. But  
tracing it down I found out that kernel32 and winex11 sync functions  
are not checking at all if the passes handles are not NULLs.

So I'm not sure whether this patch is right or not, but I believe we  
shouldn't bother wineserver with NULL handles!?
Yet maybe I don't understand clearly the way interserver communication  
works, and sending "WaitFor" with NULL handle makes sense. Does it?

Cheers,
-- 
Adam Strzelecki |: nanoant.com :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: WaitForMultipleObjectsEx ignore NULL handles.patch
Type: application/octet-stream
Size: 2243 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080229/1197b1d6/attachment.obj 


More information about the wine-patches mailing list