[PATCH] quartz: Compare a file handle to INVALID_HANDLE_VALUE and not NULL.

Michael Stefaniuc mstefani at redhat.de
Wed Jul 9 16:54:28 CDT 2008


Found by Smatch.

This "fixes" the test output for me from:
avisplitter.c:218: Tests skipped: test.avi is not an avi riff file, not doing the avi splitter test
to
avisplitter.c:208: Tests skipped: Could not read test file "test.avi", skipping test
as there is no test.avi in my quartz/tests build folder.
---
 dlls/quartz/tests/avisplitter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/quartz/tests/avisplitter.c b/dlls/quartz/tests/avisplitter.c
index 3dd1615..d3cdaac 100644
--- a/dlls/quartz/tests/avisplitter.c
+++ b/dlls/quartz/tests/avisplitter.c
@@ -203,7 +203,7 @@ static void test_threads()
 
     file = CreateFileW(wfile, GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_WRITE,
         NULL, OPEN_EXISTING, 0, NULL);
-    if (!file)
+    if (file == INVALID_HANDLE_VALUE)
     {
         skip("Could not read test file \"%s\", skipping test\n", afile);
         return;
-- 
1.5.6.2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080709/7b952aae/attachment-0001.pgp 


More information about the wine-patches mailing list