[PATCH 01/10][try 2] quartz: Make Filtermapper aggregatable.

Alexander Dorofeyev alexd4 at inbox.lv
Thu Jul 17 12:24:15 CDT 2008


Alexandre Julliard wrote:
 > Alexander Dorofeyev <alexd4 at inbox.lv> writes:
 >
 >> @@ -1148,7 +1201,7 @@ static const IFilterMapper2Vtbl fm2vtbl =
 >>
 >>  static HRESULT WINAPI FilterMapper_QueryInterface(IFilterMapper * iface, 
REFIID riid, LPVOID *ppv)
 >>  {
 >> -    FilterMapper2Impl *This = impl_from_IFilterMapper(iface);
 >> +    ICOM_THIS_MULTI(FilterMapper2Impl, lpVtblFilterMapper, iface);
 >
 > Please don't do that. Using inline functions is much better than the
 > ugly and non-typesafe ICOM_THIS_MULTI macro.
 >

I fixed this, keeping the inline functions. Other patches are unchanged, but 
I've rebased them and will resend just in case. Hope this is ok.
---
  dlls/quartz/filtermapper.c |   94 +++++++++++++++++++++++++++++++++++++------
  1 files changed, 81 insertions(+), 13 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 61ccfd2b0c153ea95662a4b347674b7f6e6b37c1.diff
Type: text/x-patch
Size: 5681 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080717/d04d6e5c/attachment.bin 


More information about the wine-patches mailing list