general question..

Stefan Dösinger stefan at codeweavers.com
Mon Jul 21 21:39:47 CDT 2008


Can you give some examples of such code? Nobody here is a goto-maniac, but
in all cases I know the goto is used for a good reason. Most of the time it
is used for error path to avoid ugly if() nesting and/or code duplication
when freeing partially allocated objects


> -----Original Message-----
> From: wine-patches-bounces at winehq.org [mailto:wine-patches-
> bounces at winehq.org] On Behalf Of Chris Ahrendt
> Sent: Monday, July 21, 2008 8:42 PM
> To: wine-patches at winehq.org
> Subject: general question..
> 
> As I have been going through trying to debug the everquest2 issues on
> my
> machine I have run into a few places where I think the code should be
> changed a little ( this alot of times is where there is a GOTO in the
> code). My question is in the case where I do find these goto's and I
> rewrite the code  should I submit the changes here for approval?
> I have been doing some code reviews and found a few places where
> there are goto's that don't need to be there. I guess I am old school
> and really dislike code with goto's (they make debugging and
> maintenance
> a nightmare (I used to maintain 20 year old cobol code  along time ago
> =) )
> 
> 
> Chris




More information about the wine-patches mailing list