oleaut32: fix the SafeArrayGetVartype tests on Vista and use that behaviour. [try 5]

Reece Dunn msclrhd at googlemail.com
Thu Jul 24 17:37:49 CDT 2008

 1 - fixed the tests for Vista.
 2 - made the old behaviour broken(), and fixed SafeArrayGetVartype to
use the correct behaviour.
 3 - fixed whitespace (use spaces instead of tabs).
 4 - simplify the test logic; found a 3rd place that had the same
pattern w.r.t. SafeArrayGetVartype so fixed that as well, adding an if
(pSafeArrayGetVartype) check to it (as that was missing in that case,
but not the others).
  5 - don't simplify the 3rd case, as this was not failing on Vista,
so does not need to be fixed!

This fixes the oleaut32/safearray tests for Vista
as it looks like Vista is returning the correct vartype for a
safearray of VT_DISPATCH objects.

This includes Rob Shearman's suggestion of marking the old behaviour
as broken() as it is clearly a bug, and also updated the
SafeArrayGetVartype implementation to return the correct value in this

The tests pass on Vista and on Wine.

- Reece
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-oleaut32-fix-the-SafeArrayGetVartype-tests-on-Vista.txt
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20080724/bcf3a4f5/attachment.txt 

More information about the wine-patches mailing list