shlwapi/tests: Fix a buffer-overflow, that result in a crash on Win9x

Detlef Riekenberg wine.dev at web.de
Sun Jul 27 16:01:06 CDT 2008


Win9x does not limit PathCanonicalizeA() to MAX_PATH.
The Function succed and overflow the output-buffer.

What should we do with the affected test in line 913?
>    ok(!res, "Expected failure\n");

Remove it completly or use broken()?

"ok(!res || broken(res), ..." looks really ugly.



-- 
 
By by ... Detlef

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-shlwapi-tests-Fix-a-buffer-overflow-that-result-in-a.txt
Type: application/mbox
Size: 0 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080727/bdf01052/attachment.bin 


More information about the wine-patches mailing list