ddraw/tests: Skip cubemap tests when cubemap isn't supported.

Stefan Dösinger stefan at codeweavers.com
Tue Jul 29 22:21:00 CDT 2008


> skip("No cubemap support\n");
if you return right after that you wouldn't have to change the indention on all the rest of the code

Also I think in the case of the surface test, there should be an easier way to tell if cubemaps are supported, without starting a d3d device. In the worst case just abort on a CreateSurface error

> -----Original Message-----
> From: wine-patches-bounces at winehq.org [mailto:wine-patches-
> bounces at winehq.org] On Behalf Of Alexander Dorofeyev
> Sent: Tuesday, July 29, 2008 5:25 PM
> To: wine-patches at winehq.org
> Subject: ddraw/tests: Skip cubemap tests when cubemap isn't supported.
> 
> 
> Fixes some test failures on systems without cubemap support.
> ---
>   dlls/ddraw/tests/d3d.c      |  428 ++++++++++++++++++++++------------
> ---------
>   dlls/ddraw/tests/dsurface.c |   57 ++++++-
>   2 files changed, 275 insertions(+), 210 deletions(-)




More information about the wine-patches mailing list