[website] Changes and translations

Jeremy Newman jnewman at codeweavers.com
Mon Jun 2 15:29:22 CDT 2008


First off, Your patch includes all your previous updates that are in the 
git tree.. Please be sure to do a "git pull" before submitting a patch.

1.) using {$path} is better than using concatenation here. I'll revise 
your patch.

2.) Don't include all the alternate ways of doing the same code. This is 
a simple line of code, we don't care if there are other ways of doing 
things. This is not a let's learn PHP site.

3.) I don't see any translations for "home" and "quotes" Did you first 
forget to do a "git add templates/es/quotes.template"?

I will commit, #1. Please correct the other issues and resubmit.

Ángel Guzmán Maeso wrote:
> Changelog:
> 1) Show path in config file not found
> 2) Use array_random() and explode() in quote function
> 3) Spanish translation for home and quotes
> -- 
> Shakaran
> 



More information about the wine-patches mailing list