wininet: InternetCrackUrlW: for URLs that have no urlpath, native clears lpszUrlPath (resend)

Dan Kegel dank at kegel.com
Mon Jun 23 23:42:51 CDT 2008


Add one more URL to the InternetCrackUrlW testcase,
fix the bug it reveals.  After the fix, tests pass on both XP and Wine.

I believe winex committed a similar fix in 2005,
http://lists.transgaming.org/pipermail/winex-devel/2005-March/000504.html

This fixes valgrind warnings like this:

 Conditional jump or move depends on uninitialised value(s)
   at HTTP_HttpOpenRequestW (http.c:1931)
   by HttpOpenRequestW (http.c:939)
   by INTERNET_InternetOpenUrlW (internet.c:2813)
   by AsyncInternetOpenUrlProc (internet.c:2855)
   by INTERNET_WorkerThreadFunc (internet.c:3044)
 Uninitialised value was created by a stack allocation
   at  INTERNET_InternetOpenUrlW (internet.c:2743)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wininet-crackurl.patch
Type: text/x-diff
Size: 2221 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080623/ef991ee7/attachment.patch 


More information about the wine-patches mailing list