[Tools] winetest: Fix the computation of the cell tooltips to not add spurious double-quotes. This fixes a bunch of HTML errors.

Francois Gouget fgouget at free.fr
Mon Mar 10 07:58:47 CDT 2008


---
 winetest/gather |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/winetest/gather b/winetest/gather
index 80aec78..a40c2f6 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -333,12 +333,17 @@ EOF
             my $href = "href=\"#$group->{name}\"";
             if (exists $group->{extrema}->{$testname}) {
                 my ($min,$max) = @{$group->{extrema}->{$testname}};
-                my $class = $min==0?($max==0?"pass":"mixed"):"fail";
-                my $title = $min==0?"":" title=\"Best: $min";
-                my $errors = $min==$max?$min:"$min to $max";
                 my $todos = (exists $group->{todo}->{$testname})?"todo_":"";
-                $title = (exists $group->{todo}->{$testname})?"$title, Todo: $group->{todo}->{$testname}\"":"$title\"";
                 my $skip = (exists $group->{skipped}->{$testname})?"skip_":"";
+                my $class = $min==0?($max==0?"pass":"mixed"):"fail";
+                my $title = "";
+                if ($min)
+                {
+                    $title = " title=\"Best: $min";
+                    $title.= ", Todo: $group->{todo}->{$testname}" if (exists $group->{todo}->{$testname});
+                    $title.="\"";
+                }
+                my $errors = $min==$max?$min:"$min to $max";
                 print OUT <<"EOF";
       <td class="$todos$skip$class"><a $href$title
         onMouseOver="refresh('$testname','$group->{name}','-','-','$errors');"
-- 
1.5.4.1




More information about the wine-patches mailing list