[PATCH] (msi) initialize variables

Marcus Meissner marcus at jet.franken.de
Thu Mar 13 15:54:48 CDT 2008


Hi,

Coverity spotted we might call msi_free(name) and (disp)
on uninitialized name or disp (in some goto done; paths).

Fixed.

Ciao, Marcus
---
 dlls/msi/action.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 2e5b8ee..8e753bf 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -4471,7 +4471,7 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
     MSIFILE *file;
     SC_HANDLE hscm, service = NULL;
     LPCWSTR comp, depends, pass;
-    LPWSTR name, disp;
+    LPWSTR name = NULL, disp = NULL;
     LPCWSTR load_order, serv_name, key;
     DWORD serv_type, start_type;
     DWORD err_control;
-- 
1.5.2.4



More information about the wine-patches mailing list