[Tools 3/7] winetest: Rename a $_ variable to $group for clarity.

Francois Gouget fgouget at free.fr
Fri Mar 14 13:56:31 CDT 2008


---

It's clearer what '$group' is than '$_'.


 winetest/gather |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/winetest/gather b/winetest/gather
index 301485f..c37e4c1 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -203,24 +203,24 @@ foreach my $group (@groups) {
 # Write out the tables
 
 my ($header);                   # same in thead and tfoot
-foreach (@groups) {
-    if (exists $_->{reports}) {
-        my $report_count = @{$_->{reports}};
+foreach my $group (@groups) {
+    if (exists $group->{reports}) {
+        my $report_count = @{$group->{reports}};
         if ($report_count > 1) {
-            $header .= "      <th><a href=\"#$_->{name}\">$_->{name}<br><small>$report_count reports</small></a></th>\n";
+            $header .= "      <th><a href=\"#$group->{name}\">$group->{name}<br><small>$report_count reports</small></a></th>\n";
         } else {
-            my $report = $_->{reports}->[0];
+            my $report = $group->{reports}->[0];
             # If dllinfo.txt exist we use a different layout (new style report)
             if (-r "$datadir/$build/$report->{dir}/dllinfo.txt") {
                 $header .= <<"EOF";
-    <th>$_->{name}<br><small>
+    <th>$group->{name}<br><small>
         <a href=\"$report->{dir}/version.txt\">$report->{tag}</a><br>
         <a href=\"$report->{dir}/dllinfo.txt\">[info]</a>
         <a href=\"$report->{dir}/report\">[file]</a></small></th>
 EOF
             } else {
                 $header .= <<"EOF";
-    <th>$_->{name}<br><small>
+    <th>$group->{name}<br><small>
         <a href=\"$report->{dir}/build.txt\">$report->{tag}</a><br>
         <a href=\"$report->{dir}/version.txt\">[info]</a>
         <a href=\"$report->{dir}/report\">[file]</a></small></th>
-- 
1.5.4.1




More information about the wine-patches mailing list