[Tools 1/6] winetest: Make sure the 'name' attribute does not start with a digit so it is compatible with the 'id' one. This fixes an HTML warning on pages containing multiple 2000 or 2003 reports.

Francois Gouget fgouget at free.fr
Mon Mar 17 06:17:17 CDT 2008


---

So the 'name' attribute seems to be deprecated and to be replaced with 
the 'id' attribute, probably to match XML. Still one can keep using 
name, but to ensure compatibility with the id attribute, its value 
should start with a letter.

 winetest/gather |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/winetest/gather b/winetest/gather
index b0e4d7d..8ec43bd 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -226,7 +226,7 @@ foreach my $group (@groups) {
     if (exists $group->{reports}) {
         my $report_count = @{$group->{reports}};
         if ($report_count > 1) {
-            $header .= "      <th><a href=\"#$group->{name}\">$group->{name}<br><small>$report_count reports</small></a></th>\n";
+            $header .= "      <th><a href=\"#group_$group->{name}\">$group->{name}<br><small>$report_count reports</small></a></th>\n";
         } else {
             my $report = $group->{reports}->[0];
             # If dllinfo.txt exist we use a different layout (new style report)
@@ -372,7 +372,7 @@ EOF
         } elsif (@{$group->{reports}} == 1) {
             singletest($group->{reports}->[0], $testname, $group->{name});
         } else {
-            my $href = "href=\"#$group->{name}\"";
+            my $href = "href=\"#group_$group->{name}\"";
             if (exists $group->{extrema}->{$testname}) {
                 my ($min,$max) = @{$group->{extrema}->{$testname}};
                 my $todos = (exists $group->{todo}->{$testname})?"todo_":"";
@@ -428,7 +428,7 @@ EOF
 
     print OUT <<"EOF";
 <hr>
-<h2><a name="$group->{name}">$group->{name} differences</a></h2>
+<h2><a name="group_$group->{name}">$group->{name} differences</a></h2>
 <table class="report">
   <thead>
     <tr>
-- 
1.5.4.3




More information about the wine-patches mailing list