[Tools 1/6] winetest: Simplify the legacy missing dll handling.
Francois Gouget
fgouget at free.fr
Wed Mar 26 17:34:40 CDT 2008
---
This way $report->{results}->{$testname} is set in just one place too
for missing dlls.
winetest/gather | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/winetest/gather b/winetest/gather
index ee49f4a..8cfd1ab 100755
--- a/winetest/gather
+++ b/winetest/gather
@@ -134,17 +134,13 @@ foreach my $file (glob "$datadir/$build/*/summary.txt") {
$source, $rev) = split;
my $testname = "$dll:$unit";
# Leave this in for older type reports
- if ($unit =~ /_dll_missing/) {
+ if ($unit =~ /_dll_missing/ or
+ ($count eq "0" and exists $report->{dllmissing}->{$dll})) {
# Mark the dll as missing on this system
$report->{dllmissing}->{$dll} = 1;
next;
}
- if ($count eq "0" and exists $report->{dllmissing}->{$dll}) {
- # Mark this test as missing because of a missing dll
- $report->{results}->{$testname} = ["dll missing", "-", "-", "-"];
- } else {
- $report->{results}->{$testname} = [$count, $todo, $error, $skipped];
- }
+ $report->{results}->{$testname} = [$count, $todo, $error, $skipped];
if ($rev =~ /\./) {
$alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"")
unless exists $alltests{$testname};
--
1.5.4.3
More information about the wine-patches
mailing list