[1/2] advpack: Add some error handling to get_dest_dir.

Michael Karcher wine at mkarcher.dialup.fu-berlin.de
Wed May 28 03:15:10 CDT 2008


This patch is intended to break an advpack test (line 441), which
already broke with no optimization on Ubuntu gutsy's gcc 4.1, and
usually worked just by chance.

Alexandre: If you do not want the broken test to show up, merge this
patch with the [2/2] following, which fixes the original bug. Alas, they
are not independent.
If you just want a bug fix for the testcase because of the freeze, and
still leave the dangerous access to uninitialized memory in, I will
prepare a simpler patch, the minimal patch to make the testcase
definitely pass is two lines. (but I don't want to encourage that
decision which would be, in my oppinion, wrong, even in a freeze).
---
 dlls/advpack/advpack.c |   72 ++++++++++++++++++++++++++++++-----------------
 1 files changed, 46 insertions(+), 26 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3be2065a7c4bf9ad6a6015dea49ad2f4eae6003c.diff
Type: text/x-patch
Size: 4652 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080528/4e854ff0/attachment-0001.bin 


More information about the wine-patches mailing list