[PATCH] Fix crashes on win98

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Fri May 30 05:49:50 CDT 2008


---
 dlls/msxml3/tests/xmldoc.c  |  247 ++++++++++++++++++-----------------
 dlls/msxml3/tests/xmlelem.c |  312 ++++++++++++++++++++++---------------------
 2 files changed, 286 insertions(+), 273 deletions(-)

diff --git a/dlls/msxml3/tests/xmldoc.c b/dlls/msxml3/tests/xmldoc.c
index 076d1fe..19cee90 100644
--- a/dlls/msxml3/tests/xmldoc.c
+++ b/dlls/msxml3/tests/xmldoc.c
@@ -28,6 +28,9 @@
 
 #include "wine/test.h"
 
+/* Deprecated Error Codes */
+#define XML_E_INVALIDATROOTLEVEL    0xc00ce556
+
 static void append_str(char **str, const char *data)
 {
     sprintf(*str, data);
@@ -113,127 +116,131 @@ static void test_xmldoc(void)
     ok(element == NULL, "Expected NULL element\n");
 
     hr = IPersistStreamInit_Load(psi, stream);
-    ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
+    ok(hr == S_OK || hr == XML_E_INVALIDATROOTLEVEL, "Expected S_OK, got %08x\n", hr);
     ok(stream != NULL, "Expected non-NULL stream\n");
-
-    hr = IXMLDocument_get_root(doc, &element);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(element != NULL, "Expected non-NULL element\n");
-
-    hr = IXMLElement_get_type(element, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
-
-    hr = IXMLElement_get_tagName(element, &name);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(name, szBankAccount), "Expected BANKACCOUNT\n");
-    SysFreeString(name);
-
-    hr = IXMLElement_get_children(element, &collection);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(collection != NULL, "Expected non-NULL collection\n");
-
-    hr = IXMLElementCollection_get_length(collection, &num_child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(num_child == 2, "Expected 2, got %ld\n", num_child);
-
-    V_VT(&vIndex) = VT_I4;
-    V_I4(&vIndex) = 0;
-    V_VT(&vName) = VT_ERROR;
-    V_ERROR(&vName) = DISP_E_PARAMNOTFOUND;
-    hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(child != NULL, "Expected non-NULL child\n");
-
-    hr = IXMLElement_get_type(child, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
-
-    hr = IXMLElement_get_tagName(child, &name);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(name, szNumber), "Expected NUMBER\n");
-    SysFreeString(name);
-
-    hr = IXMLElement_get_children(child, &inner);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(inner != NULL, "Expected non-NULL inner\n");
-
-    hr = IXMLElementCollection_get_length(inner, &num_child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(num_child == 1, "Expected 1, got %ld\n", num_child);
-
-    hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(value != NULL, "Expected non-NULL value\n");
-
-    hr = IXMLElement_get_type(value, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type);
-
-    hr = IXMLElement_get_text(value, &name);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(name, szNumVal), "Expected '1234'\n");
-    SysFreeString(name);
-
-    IXMLElementCollection_Release(inner);
-
-    inner = (IXMLElementCollection *)0xdeadbeef;
-    hr = IXMLElement_get_children(value, &inner);
-    ok(hr == 1, "Expected 1, got %d\n", hr);
-    ok(inner == NULL, "Expected NULL inner, got %p\n", inner);
-
-    IXMLElement_Release(value);
-    IXMLElement_Release(child);
-    value = NULL;
-    child = NULL;
-
-    V_I4(&vIndex) = 1;
-    hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(child != NULL, "Expected non-NULL child\n");
-
-    hr = IXMLElement_get_type(child, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
-
-    hr = IXMLElement_get_tagName(child, &name);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(name, szName), "Expected NAME\n");
-    SysFreeString(name);
-
-    hr = IXMLElement_get_children(child, &inner);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(inner != NULL, "Expected non-NULL inner\n");
-
-    hr = IXMLElementCollection_get_length(inner, &num_child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(num_child == 1, "Expected 1, got %ld\n", num_child);
-
-    V_I4(&vIndex) = 0;
-    hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(value != NULL, "Expected non-NULL value\n");
-
-    hr = IXMLElement_get_type(value, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type);
-
-    hr = IXMLElement_get_text(value, &name);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(name, szNameVal), "Expected 'Captain Ahab'\n");
-    SysFreeString(name);
-
-    IXMLElementCollection_Release(inner);
-
-    inner = (IXMLElementCollection *)0xdeadbeef;
-    hr = IXMLElement_get_children(value, &inner);
-    ok(hr == 1, "Expected 1, got %d\n", hr);
-    ok(inner == NULL, "Expected NULL inner, got %p\n", inner);
-
-    IXMLElement_Release(value);
-    IXMLElement_Release(child);
-    IXMLElementCollection_Release(collection);
-    IXMLElement_Release(element);
+    if(hr == S_OK)
+    {
+        hr = IXMLDocument_get_root(doc, &element);
+        ok(hr == S_OK || hr == XML_E_INVALIDATROOTLEVEL, "Expected S_OK, got %d\n", hr);
+    
+        ok(element != NULL, "Expected non-NULL element\n");
+        
+        hr = IXMLElement_get_type(element, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
+
+        hr = IXMLElement_get_tagName(element, &name);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(name, szBankAccount), "Expected BANKACCOUNT\n");
+        SysFreeString(name);
+
+        hr = IXMLElement_get_children(element, &collection);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(collection != NULL, "Expected non-NULL collection\n");
+
+        hr = IXMLElementCollection_get_length(collection, &num_child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(num_child == 2, "Expected 2, got %ld\n", num_child);
+
+        V_VT(&vIndex) = VT_I4;
+        V_I4(&vIndex) = 0;
+        V_VT(&vName) = VT_ERROR;
+        V_ERROR(&vName) = DISP_E_PARAMNOTFOUND;
+        hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(child != NULL, "Expected non-NULL child\n");
+
+        hr = IXMLElement_get_type(child, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
+
+        hr = IXMLElement_get_tagName(child, &name);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(name, szNumber), "Expected NUMBER\n");
+        SysFreeString(name);
+
+        hr = IXMLElement_get_children(child, &inner);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(inner != NULL, "Expected non-NULL inner\n");
+
+        hr = IXMLElementCollection_get_length(inner, &num_child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(num_child == 1, "Expected 1, got %ld\n", num_child);
+
+        hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(value != NULL, "Expected non-NULL value\n");
+
+        hr = IXMLElement_get_type(value, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type);
+
+        hr = IXMLElement_get_text(value, &name);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(name, szNumVal), "Expected '1234'\n");
+        SysFreeString(name);
+
+        IXMLElementCollection_Release(inner);
+
+        inner = (IXMLElementCollection *)0xdeadbeef;
+        hr = IXMLElement_get_children(value, &inner);
+        ok(hr == 1, "Expected 1, got %d\n", hr);
+        ok(inner == NULL, "Expected NULL inner, got %p\n", inner);
+
+        IXMLElement_Release(value);
+        IXMLElement_Release(child);
+        value = NULL;
+        child = NULL;
+
+        V_I4(&vIndex) = 1;
+        hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(child != NULL, "Expected non-NULL child\n");
+
+        hr = IXMLElement_get_type(child, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
+
+        hr = IXMLElement_get_tagName(child, &name);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(name, szName), "Expected NAME\n");
+        SysFreeString(name);
+
+        hr = IXMLElement_get_children(child, &inner);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(inner != NULL, "Expected non-NULL inner\n");
+
+        hr = IXMLElementCollection_get_length(inner, &num_child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(num_child == 1, "Expected 1, got %ld\n", num_child);
+
+        V_I4(&vIndex) = 0;
+        hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(value != NULL, "Expected non-NULL value\n");
+
+        hr = IXMLElement_get_type(value, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type);
+
+        hr = IXMLElement_get_text(value, &name);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(name, szNameVal), "Expected 'Captain Ahab'\n");
+        SysFreeString(name);
+
+        IXMLElementCollection_Release(inner);
+
+        inner = (IXMLElementCollection *)0xdeadbeef;
+        hr = IXMLElement_get_children(value, &inner);
+        ok(hr == 1, "Expected 1, got %d\n", hr);
+        ok(inner == NULL, "Expected NULL inner, got %p\n", inner);
+
+        IXMLElement_Release(value);
+        IXMLElement_Release(child);
+        IXMLElementCollection_Release(collection);
+        IXMLElement_Release(element);        
+    }
+    
     IStream_Release(stream);
     IPersistStreamInit_Release(psi);
     IXMLDocument_Release(doc);
diff --git a/dlls/msxml3/tests/xmlelem.c b/dlls/msxml3/tests/xmlelem.c
index 61a2300..3b3be42 100644
--- a/dlls/msxml3/tests/xmlelem.c
+++ b/dlls/msxml3/tests/xmlelem.c
@@ -30,6 +30,8 @@
 
 #include "wine/test.h"
 
+#define ERROR_URL_NOT_FOUND 0x800c0006
+
 static void test_xmlelem(void)
 {
     HRESULT hr;
@@ -280,160 +282,164 @@ static void test_xmlelem_collection(void)
     GetFullPathNameW(szBankXML, MAX_PATH, path, NULL);
 
     url = SysAllocString(path);
-    hr = IXMLDocument_put_URL(doc, url);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+    hr = IXMLDocument_put_URL(doc, url);    
+    /* Win98 returns ERROR_URL_NOT_FOUND */
+    ok(hr == S_OK || hr == ERROR_URL_NOT_FOUND, "Expected S_OK, got 0x%08x\n", hr);
     SysFreeString(url);
-
-    hr = IXMLDocument_get_root(doc, &element);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(element != NULL, "Expected non-NULL element\n");
-
-    hr = IXMLElement_get_children(element, &collection);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(collection != NULL, "Expected non-NULL collection\n");
-
-    hr = IXMLElementCollection_get_length(collection, NULL);
-    ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %d\n", hr);
-
-    hr = IXMLElementCollection_get_length(collection, &length);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(length == 2, "Expected 2, got %ld\n", length);
-
-    /* IXMLElementCollection:put_length does nothing */
-    hr = IXMLElementCollection_put_length(collection, -1);
-    ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
-
-    hr = IXMLElementCollection_put_length(collection, 0);
-    ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
-
-    hr = IXMLElementCollection_put_length(collection, 1);
-    ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
-
-    hr = IXMLElementCollection_put_length(collection, 2);
-    ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
-
-    hr = IXMLElementCollection_put_length(collection, 3);
-    ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
-
-    hr = IXMLElementCollection_put_length(collection, 50);
-    ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
-
-    /* make sure the length hasn't changed */
-    hr = IXMLElementCollection_get_length(collection, &length);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(length == 2, "Expected 2, got %ld\n", length);
-
-    /* IXMLElementCollection implements IEnumVARIANT */
-    hr = IXMLElementCollection_QueryInterface(collection, &IID_IEnumVARIANT, (LPVOID *)&enumVar);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(enumVar != NULL, "Expected non-NULL enumVar\n");
-    IEnumVARIANT_Release(enumVar);
-
-    hr = IXMLElementCollection_get__newEnum(collection, &unk);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(unk != NULL, "Expected non-NULL unk\n");
-
-    hr = IUnknown_QueryInterface(unk, &IID_IEnumVARIANT, (LPVOID *)&enumVar);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(enumVar != NULL, "Expected non-NULL enumVar\n");
-    IUnknown_Release(unk);
-
-    /* <Number>1234</Number> */
-    hr = IEnumVARIANT_Next(enumVar, 1, &var, &num_vars);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(V_VT(&var) == VT_DISPATCH, "Expected VT_DISPATCH, got %d\n", V_VT(&var));
-    ok(num_vars == 1, "Expected 1, got %d\n", 1);
-
-    hr = IUnknown_QueryInterface(V_DISPATCH(&var), &IID_IXMLElement, (LPVOID *)&child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(child != NULL, "Expected non-NULL child\n");
-
-    VariantClear(&var);
-
-    hr = IXMLElement_get_type(child, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
-
-    hr = IXMLElement_get_tagName(child, &str);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(str, szNumber), "Expected NUMBER\n");
-    SysFreeString(str);
-    IXMLElement_Release(child);
-
-    /* <Name>Captain Ahab</Name> */
-    hr = IEnumVARIANT_Next(enumVar, 1, &var, &num_vars);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(V_VT(&var) == VT_DISPATCH, "Expected VT_DISPATCH, got %d\n", V_VT(&var));
-    ok(num_vars == 1, "Expected 1, got %d\n", 1);
-
-    hr = IUnknown_QueryInterface(V_DISPATCH(&var), &IID_IXMLElement, (LPVOID *)&child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(child != NULL, "Expected non-NULL child\n");
-
-    VariantClear(&var);
-
-    hr = IXMLElement_get_type(child, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
-
-    hr = IXMLElement_get_tagName(child, &str);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(str, szName), "Expected NAME\n");
-    SysFreeString(str);
-    IXMLElement_Release(child);
-
-    /* <Number>1234</Number> */
-    V_VT(&vIndex) = VT_I4;
-    V_I4(&vIndex) = 0;
-    V_VT(&vName) = VT_ERROR;
-    V_ERROR(&vName) = DISP_E_PARAMNOTFOUND;
-    hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(child != NULL, "Expected non-NULL child\n");
-
-    hr = IXMLElement_get_type(child, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
-
-    hr = IXMLElement_get_tagName(child, &str);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(str, szNumber), "Expected NUMBER\n");
-    SysFreeString(str);
-    IXMLElement_Release(child);
-
-    /* <Name>Captain Ahab</Name> */
-    V_VT(&vIndex) = VT_I4;
-    V_I4(&vIndex) = 1;
-    V_VT(&vName) = VT_ERROR;
-    V_ERROR(&vName) = DISP_E_PARAMNOTFOUND;
-    hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(child != NULL, "Expected non-NULL child\n");
-
-    hr = IXMLElement_get_type(child, &type);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
-
-    hr = IXMLElement_get_tagName(child, &str);
-    ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
-    ok(!lstrcmpW(str, szName), "Expected NAME\n");
-    SysFreeString(str);
-    IXMLElement_Release(child);
-
-    V_I4(&vIndex) = 100;
-    hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
-    ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
-    ok(child == NULL, "Expected NULL child\n");
-
-    V_I4(&vIndex) = -1;
-    child = (IXMLElement *)0xdeadbeef;
-    hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
-    ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %d\n", hr);
-    ok(child == NULL, "Expected NULL child\n");
-
-    IEnumVARIANT_Release(enumVar);
-    IXMLElement_Release(element);
-    IXMLElementCollection_Release(collection);
+    if(hr == S_OK)
+    {
+        hr = IXMLDocument_get_root(doc, &element);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(element != NULL, "Expected non-NULL element\n");
+
+        hr = IXMLElement_get_children(element, &collection);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(collection != NULL, "Expected non-NULL collection\n");
+
+        hr = IXMLElementCollection_get_length(collection, NULL);
+        ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %d\n", hr);
+
+        hr = IXMLElementCollection_get_length(collection, &length);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(length == 2, "Expected 2, got %ld\n", length);
+
+        /* IXMLElementCollection:put_length does nothing */
+        hr = IXMLElementCollection_put_length(collection, -1);
+        ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
+
+        hr = IXMLElementCollection_put_length(collection, 0);
+        ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
+
+        hr = IXMLElementCollection_put_length(collection, 1);
+        ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
+
+        hr = IXMLElementCollection_put_length(collection, 2);
+        ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
+
+        hr = IXMLElementCollection_put_length(collection, 3);
+        ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
+
+        hr = IXMLElementCollection_put_length(collection, 50);
+        ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
+
+        /* make sure the length hasn't changed */
+        hr = IXMLElementCollection_get_length(collection, &length);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(length == 2, "Expected 2, got %ld\n", length);
+
+        /* IXMLElementCollection implements IEnumVARIANT */
+        hr = IXMLElementCollection_QueryInterface(collection, &IID_IEnumVARIANT, (LPVOID *)&enumVar);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(enumVar != NULL, "Expected non-NULL enumVar\n");
+        IEnumVARIANT_Release(enumVar);
+
+        hr = IXMLElementCollection_get__newEnum(collection, &unk);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(unk != NULL, "Expected non-NULL unk\n");
+
+        hr = IUnknown_QueryInterface(unk, &IID_IEnumVARIANT, (LPVOID *)&enumVar);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(enumVar != NULL, "Expected non-NULL enumVar\n");
+        IUnknown_Release(unk);
+
+        /* <Number>1234</Number> */
+        hr = IEnumVARIANT_Next(enumVar, 1, &var, &num_vars);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(V_VT(&var) == VT_DISPATCH, "Expected VT_DISPATCH, got %d\n", V_VT(&var));
+        ok(num_vars == 1, "Expected 1, got %d\n", 1);
+
+        hr = IUnknown_QueryInterface(V_DISPATCH(&var), &IID_IXMLElement, (LPVOID *)&child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(child != NULL, "Expected non-NULL child\n");
+
+        VariantClear(&var);
+
+        hr = IXMLElement_get_type(child, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
+
+        hr = IXMLElement_get_tagName(child, &str);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(str, szNumber), "Expected NUMBER\n");
+        SysFreeString(str);
+        IXMLElement_Release(child);
+
+        /* <Name>Captain Ahab</Name> */
+        hr = IEnumVARIANT_Next(enumVar, 1, &var, &num_vars);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(V_VT(&var) == VT_DISPATCH, "Expected VT_DISPATCH, got %d\n", V_VT(&var));
+        ok(num_vars == 1, "Expected 1, got %d\n", 1);
+
+        hr = IUnknown_QueryInterface(V_DISPATCH(&var), &IID_IXMLElement, (LPVOID *)&child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(child != NULL, "Expected non-NULL child\n");
+
+        VariantClear(&var);
+
+        hr = IXMLElement_get_type(child, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
+
+        hr = IXMLElement_get_tagName(child, &str);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(str, szName), "Expected NAME\n");
+        SysFreeString(str);
+        IXMLElement_Release(child);
+
+        /* <Number>1234</Number> */
+        V_VT(&vIndex) = VT_I4;
+        V_I4(&vIndex) = 0;
+        V_VT(&vName) = VT_ERROR;
+        V_ERROR(&vName) = DISP_E_PARAMNOTFOUND;
+        hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(child != NULL, "Expected non-NULL child\n");
+
+        hr = IXMLElement_get_type(child, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
+
+        hr = IXMLElement_get_tagName(child, &str);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(str, szNumber), "Expected NUMBER\n");
+        SysFreeString(str);
+        IXMLElement_Release(child);
+
+        /* <Name>Captain Ahab</Name> */
+        V_VT(&vIndex) = VT_I4;
+        V_I4(&vIndex) = 1;
+        V_VT(&vName) = VT_ERROR;
+        V_ERROR(&vName) = DISP_E_PARAMNOTFOUND;
+        hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(child != NULL, "Expected non-NULL child\n");
+
+        hr = IXMLElement_get_type(child, &type);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
+
+        hr = IXMLElement_get_tagName(child, &str);
+        ok(hr == S_OK, "Expected S_OK, got %d\n", hr);
+        ok(!lstrcmpW(str, szName), "Expected NAME\n");
+        SysFreeString(str);
+        IXMLElement_Release(child);
+
+        V_I4(&vIndex) = 100;
+        hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
+        ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
+        ok(child == NULL, "Expected NULL child\n");
+
+        V_I4(&vIndex) = -1;
+        child = (IXMLElement *)0xdeadbeef;
+        hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
+        ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %d\n", hr);
+        ok(child == NULL, "Expected NULL child\n");
+
+        IEnumVARIANT_Release(enumVar);
+        IXMLElement_Release(element);
+        IXMLElementCollection_Release(collection);
+    }
+    
     IXMLDocument_Release(doc);
     DeleteFileA("bank.xml");
 }
-- 
1.5.4.1


--------------000202010307020607000902--




More information about the wine-patches mailing list