[PATCH] wininet: removed redundant NULL check (coverity)

Marcus Meissner marcus at jet.franken.de
Sat Nov 1 03:40:59 CDT 2008


Hi,

CID 803, the if (!STHook) check is not necessary,
since this if() is only entered if the lpBuffer variable,
which is assigned to STHook is not NULL.

So its truely superflous.

ciao, Marcus
---
 dlls/wininet/http.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index a3d04d9..e088fa4 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -2354,8 +2354,6 @@ static BOOL HTTP_HttpQueryInfoW( LPWININETHTTPREQW lpwhr, DWORD dwInfoLevel,
 
         tmpTM = *gmtime(&tmpTime);
         STHook = (SYSTEMTIME *)lpBuffer;
-        if (!STHook) return bSuccess;
-
         STHook->wDay = tmpTM.tm_mday;
         STHook->wHour = tmpTM.tm_hour;
         STHook->wMilliseconds = 0;
-- 
1.5.6



More information about the wine-patches mailing list