[PATCH 1/4] advapi32: GetFileSecurity() add TRACE

Paul Bryan Roberts pbronline-wine at yahoo.co.uk
Wed Nov 5 01:01:40 CST 2008


This is a resubmission

This patch has been simplified.
The conformance tests added while learning how GetFileSecuriy behaves 
under Windows are withdrawn.
It now merely adds TRACE to GetFileSecurity().


Detailed description of original submission:

This patch is one a series intended to fix Bug 14434 (WordPerfect Office
2002:  Unable to Install).

The problem here is that the installer calls GetFileSecurity() on
directories, not files while the Wine server only has support for this
API call for files, not directories.

The solution seems simple - implement support for directories by cloning
the support for files.  Provided, of course, that this is backed up by
cloning the conformance tests.

The problem here is that there are no conformance tests to clone.

This patch adds a couple of conformance tests that check 'error' return
codes.  GetFileSecurity() is expected to be called twice - once to find
out how much memory to allocate and again once the memory has been
allocated.  It seems the Windows implementation is a bit fussy and the
implementation of GetFileSecurity() was changed to match.

Conformance tests checked again W2K and WXP.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-advapi32-GetFileSecurity-add-TRACE.txt
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20081105/b0ea423e/attachment-0001.txt 


More information about the wine-patches mailing list