ConvertStringSecurityDescriptorToSecurityDescriptor - more tests (pass)

Paul Bryan Roberts pbronline-wine at
Mon Oct 13 16:23:40 CDT 2008

A second attempt that, I hope, takes into account feedback from James 

Original correction to ParseStringAclToAcl() to set missing error code 

Gratuitous setting of invalid parameter withdrawn.

Replaced with check for NULL on StringSecurityDescriptor parameter in 
both A and W forms of ConvertStringSecurityDescriptorToSecurityDescriptor.

New checks backed up by additional test cases.

Two instances of "highly superfluous" TRACE removed as suggested by JH,

Issue - unable to add test cases that show

if (GetVersion() & 0x80000000)

should precede checks for NULL parameters.  What to do ?  Drop patch 
altogether ?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ConvertStringSecurityDescriptorToSecurityDescriptor.patch
Type: text/x-diff
Size: 0 bytes
Desc: not available
Url : 

More information about the wine-patches mailing list