msxml3: Initialize xmldoc->_private in IPersistStream::Load for IXMLDOMDocument

Michael Karcher wine at
Tue Oct 14 16:51:51 CDT 2008

Now that _private is interpreted as pointer instead of reference count,
this field being uninitialized (often zero) causes visible damage, it
previously did not. Thanks to Alistair Leslie-Hughes for noting
this regression. Fixes an MS Money crash very early during startup.
 dlls/msxml3/domdoc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
index d03d8c7..8ef0db4 100644
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -330,6 +330,7 @@ static HRESULT WINAPI xmldoc_IPersistStream_Load(
         return E_FAIL;
+    xmldoc->_private = create_priv();
     attach_xmlnode( This->node, (xmlNodePtr)xmldoc );
     return S_OK;

More information about the wine-patches mailing list