[PATCH 08/12] (resend) LookupAccountSidW() - handles first user account
Paul Bryan Roberts
pbronline-wine at yahoo.co.uk
Tue Oct 21 01:29:47 CDT 2008
LookupAccountNameW() has a stubbed but non-empty, incomplete, buggy
implementation. It fails a number of unit tests but Wine code relies on
This is series of patches that provide what may be a reasonable first
pass implementation of LookupAccountNameA() and LookupAccountNameW() that:
- passes existing units tests for LookupAccountName
- works for well known SIDs
- works for 'first user account'
- allows progress towards the resolution of Bug 14334
The conformance tests for LookupAccountName() use LookupAccountSid() so
if the former is to support the 'first user account' SID then so must
the latter and the latter needs prior implementation.
Wot, no unit test ?
No - there already is one. It just doesn't as a failure. Here's the
before and after output from my Wine test VM followed by the
'equivalent' from my native Windows test VM:
before: security.c:1109: S-1-5-21-1548840911-2268645679-1347247377-1000
couldn't be mapped
after: security.c:1107: S-1-5-21-1548840911-2268645679-1347247377-1000
before: security.c:1107: S-1-5-21-1715567821-287218729-725345543-1000
after: security.c:1107: S-1-5-21-1715567821-287218729-725345543-1000
Why remove the trace from LookupAccountSidA() ? 'cos I was admonished
for not removing 'superflous' trace in an earlier submission.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the wine-patches