[PATCH] msxml3: fixed NULL ptr derefence possibilities (coverity)
Marcus Meissner
marcus at jet.franken.de
Thu Oct 30 18:17:44 CDT 2008
Hi,
Coverity CID 810, xsltSS is derferenced outside of
a if (xsltSS) check. I have to agree.
Ciao, Marcus
---
dlls/msxml3/node.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index 3162f82..1d99be3 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -1339,12 +1339,12 @@ static HRESULT WINAPI xmlnode_transformNode(
}
}
xmlFreeDoc(result);
+ /* libxslt "helpfully" frees the XML document the stylesheet was
+ generated from, too */
+ xsltSS->doc = NULL;
+ xsltFreeStylesheet(xsltSS);
}
- /* libxslt "helpfully" frees the XML document the stylesheet was
- generated from, too */
- xsltSS->doc = NULL;
- xsltFreeStylesheet(xsltSS);
IXMLDOMNode_Release(ssNew);
}
--
1.5.6
More information about the wine-patches
mailing list