LookupAccountNameW() use ACCOUNT_SIDS domain and name_use fields for well known SIDs
Paul Bryan Roberts
pbronline-wine at yahoo.co.uk
Fri Sep 26 05:52:43 CDT 2008
LookupAccountNameW() has a stubbed but non-empty, incomplete, buggy
implementation. It fails a number of unit tests but Wine code relies on
This is the FOURTH of a series of NINE patches that provide what may be
a reasonable first pass implementation of LookupAccountNameA() and
- works for well known SIDs
- works for 'first user account'
- adds handling of 'first user account' to LookupAccountSid
- passes existing units tests for LookupAccountName
- corrects knock-on regression failures in the advapit32/security.c
unit tests (there may be others elsewhere)
- allows progress towards the resolution of Bug 14334
This patch replace the stub implementation with code that uses the
ACCOUNT_SIDS domain and name_use fields.
This patch does not fix any units tests, nor does it break any.
Perhaps I should have added some but the only tests I could add would be
to try all well-known-SIDS, which would have introduced a load more
failing units tests and would have simply have been a distraction from
the business at hand.
While this patch may not be obviously incorrect, it is not correct and
is amended later when we have a unit test failure to correct.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the wine-patches