[PATCH] potential uninitialized use of substg.

Marcus Meissner meissner at suse.de
Sun Sep 28 15:27:29 CDT 2008


Hi,

CID 761, substg can be used uninitialized in
an error exit path.

Ciao, Marcus
---
 dlls/msi/storages.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/storages.c b/dlls/msi/storages.c
index 7b20dd9..4fb3ba0 100644
--- a/dlls/msi/storages.c
+++ b/dlls/msi/storages.c
@@ -184,7 +184,7 @@ done:
 static UINT STORAGES_set_row(struct tagMSIVIEW *view, UINT row, MSIRECORD *rec, UINT mask)
 {
     MSISTORAGESVIEW *sv = (MSISTORAGESVIEW *)view;
-    IStorage *stg, *substg;
+    IStorage *stg, *substg = NULL;
     IStream *stm;
     LPWSTR name = NULL;
     HRESULT hr;
@@ -236,7 +236,7 @@ static UINT STORAGES_set_row(struct tagMSIVIEW *view, UINT row, MSIRECORD *rec,
 done:
     msi_free(name);
 
-    IStorage_Release(substg);
+    if (substg) IStorage_Release(substg);
     IStorage_Release(stg);
     IStream_Release(stm);
 
-- 
1.5.6



More information about the wine-patches mailing list