[PATCH] mciqtz32: fixed boolean condition for null string check (Coverity 913)

Marcus Meissner marcus at jet.franken.de
Sat Apr 4 10:43:57 CDT 2009


Hi,

The && clearly needs to be a ||

Ciao, Marcus
---
 dlls/mciqtz32/mciqtz.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/mciqtz32/mciqtz.c b/dlls/mciqtz32/mciqtz.c
index 507956c..4477b74 100644
--- a/dlls/mciqtz32/mciqtz.c
+++ b/dlls/mciqtz32/mciqtz.c
@@ -172,7 +172,7 @@ static DWORD MCIQTZ_mciOpen(UINT wDevID, DWORD dwFlags,
         goto err;
     }
 
-    if (!lpOpenParms->lpstrElementName && !lstrlenW(lpOpenParms->lpstrElementName)) {
+    if (!lpOpenParms->lpstrElementName || !lstrlenW(lpOpenParms->lpstrElementName)) {
         TRACE("Invalid filename specified\n");
         goto err;
     }
-- 
1.5.6



More information about the wine-patches mailing list