[PATCH 3/3] msi: Add a NULL terminator to file->dest after reallocation.

James Hawkins truiken at gmail.com
Mon Dec 7 21:55:32 CST 2009


If the size of the buffer is smaller after the reallocation, the
string will not have a NULL terminator within the bounds of the
allocation.

This fixes two valgrind errors of the form:

Invalid read of size 2
    at  strrchrW (unicode.h:264)
    by  move_files_wildcard (action.c:5291)
    by  ITERATE_MoveFiles (action.c:5411)
    by  MSI_IterateRecords (msiquery.c:193)
    by  ACTION_MoveFiles (action.c:5436)
---
 dlls/msi/action.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-msi-Add-a-NULL-terminator-to-file-dest-after-realloc.patch
Type: text/x-patch
Size: 653 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091207/dd2984f1/attachment.bin>


More information about the wine-patches mailing list