msi: Close the original record before copying new data into it.

James Hawkins truiken at gmail.com
Thu Dec 10 19:01:12 CST 2009


This fixes several valgrind errors of the form:

8 bytes in 1 blocks are definitely lost
    at  notify_alloc (heap.c:247)
    by  RtlAllocateHeap (heap.c:1697)
    by  msi_alloc (msipriv.h:1078)
    by  strdupW (msipriv.h:1134)
    by  MSI_RecordSetStringW (record.c:583)
    by  MsiRecordSetStringW (record.c:608)
    by  RecordImpl_Invoke (automation.c:940)
    by  AutomationObject_Invoke (automation.c:398)
    by  invoke (automation.c:846)
    by  Record_StringDataPut (automation.c:1427)
    by  test_Database (automation.c:1721)
---
 dlls/msi/msipriv.h |    1 +
 dlls/msi/record.c  |    2 +-
 dlls/msi/table.c   |    3 +++
 3 files changed, 5 insertions(+), 1 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-msi-Close-the-original-record-before-copying-new-dat.patch
Type: text/x-patch
Size: 1435 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091210/fa69ccc5/attachment.bin>


More information about the wine-patches mailing list