[PATCH 5/7] msi: Simplify ITERATE_WriteEnvironmentString. Now we only allocate enough memory to exactly match the size of the constructed string. Before, we were leaving some memory uninitialized and overwriting the allocated memory in certain circum

James Hawkins truiken at gmail.com
Tue Dec 15 20:19:19 CST 2009


Fixes a few valgrind errors of the form:

Conditional jump or move depends on uninitialised value(s)
    at  RegSetValueExW (registry.c:1027)
    by  ITERATE_WriteEnvironmentString (action.c:5086)
---
 dlls/msi/action.c |   68 ++++++++++++++++++++++++++++++----------------------
 1 files changed, 39 insertions(+), 29 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-msi-Simplify-ITERATE_WriteEnvironmentString.-Now-we-.patch
Type: text/x-patch
Size: 2929 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091215/63375bc6/attachment.bin>


More information about the wine-patches mailing list