[PATCH 2/2] Add unit tests for junction points using reparse point interface

Paul TBBle Hampson Paul.Hampson at Pobox.com
Wed Jan 7 02:30:36 CST 2009


These unit tests have only been tested on WinXP so far. However, I think
it'll run on older Windows, at least as far as finding out that junction
points are not supported and skipping the tests.

No todo_wine because Wine doesn't claim to support junction points on
NTFS, so there's no test failures.

They're in kernel32 because that's where DeviceIoControl lives, although
I realised much later on that any implementation of this stuff would
actually end up in ntdll (forwarded to NtFsControlFile). So that's
trivial to change if needed.

This is the prelude to fixing bug 12401 and hence 10601, by at least
exercising the functionality, and providing a concrete working piece of
code, since the Internet is sort of vague about a lot of the fine
details of these ioctls.

Sort of inspired by Thomas Kho's patch from 2006, although I ended up
not actually using any of that code.

Resending, reduced line width to 80 columns (mostly...), better use of
FindFirst idiom and removal of one-shot ret variables, thanks to
arethusa on IRC for the most in-depth "cursory" examination I've ever
had.

Also reduced a few ok() tests again things like CloseFind to mere
trace(), since they are not really part of what's being tested.

And I fixed the spelling of junction in the patch subject... -_-

-- 
Paul "TBBle" Hampson, Paul.Hampson at Pobox.com

Shorter .sig for a more eco-friendly paperless office.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-unit-tests-for-junction-points-using-reparse-poi.patch
Type: text/x-diff
Size: 19523 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20090107/9f96395d/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20090107/9f96395d/attachment.pgp 


More information about the wine-patches mailing list