msi: Remove redundant pointer check (Coverity)

Nikolay Sivov bunglehead at gmail.com
Sun Jan 25 06:15:10 CST 2009


Summary:

'columns' pointer allocated by TABLE_CreateView is always not NULL at this point.
If it isn't allocated function exits earlier, just after TABLE_CreateView

Changelog:
    - Remove redundant pointer check (Coverity)

>From 8c833b3bde251b39fab17b60570a838f95ae47ae Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <bunglehead at gmail.com>
Date: Sun, 25 Jan 2009 15:08:58 +0300
Subject: Remove redundant pointer check (Coverity)

---
 dlls/msi/table.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/table.c b/dlls/msi/table.c
index 7cd1c71..e9c2196 100644
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -1818,7 +1818,7 @@ static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT num
 
 done:
     msiobj_release(&rec->hdr);
-    if (columns) columns->ops->delete(columns);
+    columns->ops->delete(columns);
     return r;
 }
 
-- 
1.5.6.5






More information about the wine-patches mailing list