[PATCH] msxml3: handle get_element returning NULL (coverity)

Marcus Meissner marcus at jet.franken.de
Wed Jan 28 16:25:16 CST 2009


Hi,

Coverity thinks get_element could return NULL, so handle
that case.

Ciao, Marcus
---
 dlls/msxml3/element.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/dlls/msxml3/element.c b/dlls/msxml3/element.c
index f479395..af2db5b 100644
--- a/dlls/msxml3/element.c
+++ b/dlls/msxml3/element.c
@@ -644,6 +644,7 @@ static HRESULT WINAPI domelem_getElementsByTagName(
 {
     domelem *This = impl_from_IXMLDOMElement( iface );
     LPWSTR szPattern;
+    xmlNodePtr *node;
     HRESULT hr;
 
     TRACE("(%p)->(%s,%p)\n", This, debugstr_w(bstrName), resultList);
@@ -654,7 +655,11 @@ static HRESULT WINAPI domelem_getElementsByTagName(
     lstrcpyW(szPattern+3, bstrName);
     TRACE("%s\n", debugstr_w(szPattern));
 
-    hr = queryresult_create(get_element(This), szPattern, resultList);
+    node = get_element(This);
+    if (!node)
+        hr = E_FAIL;
+    else
+        hr = queryresult_create(node, szPattern, resultList);
     HeapFree(GetProcessHeap(), 0, szPattern);
 
     return hr;
-- 
1.5.6



More information about the wine-patches mailing list