[PATCH] riched20: handle more missing allocs gracefully (Coverity)

Marcus Meissner marcus at jet.franken.de
Thu Jan 29 02:51:05 CST 2009


Hi,

CID 190. This should conclude those NULL ptr checks and breaks
on failed allocations.

Ciao, Marcus
---
 dlls/riched20/reader.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/dlls/riched20/reader.c b/dlls/riched20/reader.c
index c5a3a35..17f530d 100644
--- a/dlls/riched20/reader.c
+++ b/dlls/riched20/reader.c
@@ -219,8 +219,10 @@ void RTFInit(RTF_Info *info)
 	{
 		info->rtfTextBuf = heap_alloc (rtfBufSiz);
 		info->pushedTextBuf = heap_alloc (rtfBufSiz);
-		if (info->rtfTextBuf == NULL || info->pushedTextBuf == NULL)
+		if (info->rtfTextBuf == NULL || info->pushedTextBuf == NULL) {
 			ERR ("Cannot allocate text buffers.\n");
+			return;
+		}
 		info->rtfTextBuf[0] = info->pushedTextBuf[0] = '\0';
 	}
 
-- 
1.5.6



More information about the wine-patches mailing list