[PATCH] setupapi: don't check module for NULL (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Jan 31 14:56:25 CST 2009


Hi,

CID 347, module does not need to be checked, if it
is NULL FreeLibrary() will work anyway. And COverity
thinks it cannot be NULL here.

Ciao, Marcus
---
 dlls/setupapi/fakedll.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/setupapi/fakedll.c b/dlls/setupapi/fakedll.c
index 68166b7..d87babb 100644
--- a/dlls/setupapi/fakedll.c
+++ b/dlls/setupapi/fakedll.c
@@ -344,7 +344,7 @@ BOOL create_fake_dll( const WCHAR *name, const WCHAR *source )
     ret = build_fake_dll( h, module );
 
     CloseHandle( h );
-    if (module) FreeLibrary( module );
+    FreeLibrary( module );
     if (!ret) DeleteFileW( name );
     return ret;
 }
-- 
1.5.6



More information about the wine-patches mailing list