[PATCH] winmm: handle NULL szFileName in mmioOpen16 (Coverity)
Marcus Meissner
marcus at jet.franken.de
Sat Jan 31 15:42:44 CST 2009
Hi,
CID 207, szFilename being NULL could be dereferenced in
one path. Check that and return.
Ciao, Marcus
---
dlls/winmm/mmio.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/dlls/winmm/mmio.c b/dlls/winmm/mmio.c
index a750bf2..d3ab44b 100644
--- a/dlls/winmm/mmio.c
+++ b/dlls/winmm/mmio.c
@@ -614,6 +614,8 @@ HMMIO MMIO_Open(LPSTR szFileName, MMIOINFO* refmminfo, DWORD dwOpenFlags,
if (dwOpenFlags & (MMIO_PARSE|MMIO_EXIST)) {
char buffer[MAX_PATH];
+ if (!szFileName)
+ return (HMMIO)FALSE;
if (GetFullPathNameA(szFileName, sizeof(buffer), buffer, NULL) >= sizeof(buffer))
return (HMMIO)FALSE;
if ((dwOpenFlags & MMIO_EXIST) && (GetFileAttributesA(buffer) == INVALID_FILE_ATTRIBUTES))
--
1.5.6
More information about the wine-patches
mailing list