[3/4] comctl32/listview: Set LVIS_FOCUSED for all items with LVM_SETITEMSTATE not allowed

Nikolay Sivov bunglehead at gmail.com
Thu Jul 23 14:56:22 CDT 2009


Changelog:
    - Set LVIS_FOCUSED for all items with LVM_SETITEMSTATE not allowed

>From 359edf885f1b843d87daa06ea6066e245ab68855 Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <bunglehead at gmail.com>
Date: Thu, 23 Jul 2009 23:48:23 +0400
Subject: Set LVIS_FOCUSED for all items with LVM_SETITEMSTATE not allowed

---
 dlls/comctl32/listview.c       |    3 +++
 dlls/comctl32/tests/listview.c |    4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 05c033e..4d27ba7 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -8108,6 +8108,9 @@ static BOOL LISTVIEW_SetItemState(LISTVIEW_INFO *infoPtr, INT nItem, const LVITE
 	if ((lvItem.state & lvItem.stateMask & LVIS_SELECTED) && (infoPtr->dwStyle & LVS_SINGLESEL))
 	    return FALSE;
 
+	/* focus all isn't allowed */
+	if (lvItem.state & lvItem.stateMask & LVIS_FOCUSED) return FALSE;
+
     	/* apply to all items */
     	for (lvItem.iItem = 0; lvItem.iItem < infoPtr->nItemCount; lvItem.iItem++)
 	    if (!LISTVIEW_SetItemT(infoPtr, &lvItem, TRUE)) bResult = FALSE;
diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c
index bf87bca..1a7e5d8 100644
--- a/dlls/comctl32/tests/listview.c
+++ b/dlls/comctl32/tests/listview.c
@@ -2547,10 +2547,10 @@ static void test_ownerdata(void)
     item.state     = LVIS_FOCUSED;
     g_dump_itemchanged = TRUE;
     res = SendMessageA(hwnd, LVM_SETITEMSTATE, -1, (LPARAM)&item);
-    todo_wine expect(FALSE, res);
+    expect(FALSE, res);
     g_dump_itemchanged = FALSE;
     ok_sequence(sequences, PARENT_SEQ_INDEX, empty_seq,
-                "ownerdata focus all notification", TRUE);
+                "ownerdata focus all notification", FALSE);
     /* focus single item, remove all */
     item.stateMask = LVIS_FOCUSED;
     item.state     = LVIS_FOCUSED;
-- 
1.5.6.5







More information about the wine-patches mailing list