kernel32: Implement QueryFullProcessImageNameA (4th try)
Stefan.Leichter at camline.com
Wed Jun 10 13:39:42 CDT 2009
Am Wednesday 10 June 2009 12:16:10 schrieb Alexandre Julliard:
> Stefan Leichter <Stefan.Leichter at camline.com> writes:
> > Am Thursday 04 June 2009 12:49:58 schrieb Alexandre Julliard:
> >> I'd expect that error to be a side effect of WideCharToMultiByte, which
> >> is most likely what you want to use here. Also you have to handle buffer
> >> overflows correctly, with test cases.
> > If you like to see more test cases for the buffer overflow, please tell
> > me what you like to see tested
> The test isn't very convincing. For instance to show that the size is
> not modified you should set it to something that's clearly different,
> not to the same length you got in the previous call. Also you should
> check that the length matches the contents of the buffer, with/without
> terminating null as the case may be.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5292 bytes
Desc: not available
More information about the wine-patches