[sane.ds 2/4] Downgrade more inappropriate FIXMEs to WARNs

Jeremy White jwhite at codeweavers.com
Fri Mar 6 12:44:44 CST 2009


---
 dlls/sane.ds/ds_ctrl.c   |    3 +--
 dlls/sane.ds/sane_main.c |    8 ++++----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/dlls/sane.ds/ds_ctrl.c b/dlls/sane.ds/ds_ctrl.c
index 74390f1..f8efedf 100644
--- a/dlls/sane.ds/ds_ctrl.c
+++ b/dlls/sane.ds/ds_ctrl.c
@@ -610,7 +610,7 @@ TW_UINT16 SANE_EnableDSUserInterface (pTW_IDENTITY pOrigin,
     {
         twRC = TWRC_FAILURE;
         activeDS.twCC = TWCC_SEQERROR;
-	FIXME("sequence error %d\n", activeDS.currentState);
+	WARN("sequence error %d\n", activeDS.currentState);
     }
     else
     {
@@ -621,7 +621,6 @@ TW_UINT16 SANE_EnableDSUserInterface (pTW_IDENTITY pOrigin,
         {
             BOOL rc;
             activeDS.currentState = 5; /* Transitions to state 5 */
-		FIXME("showing UI\n");
             rc = DoScannerUI();
             pUserInterface->ModalUI = TRUE;
             if (!rc)
diff --git a/dlls/sane.ds/sane_main.c b/dlls/sane.ds/sane_main.c
index 55b5b90..6341d3d 100644
--- a/dlls/sane.ds/sane_main.c
+++ b/dlls/sane.ds/sane_main.c
@@ -388,7 +388,7 @@ static TW_UINT16 SANE_SourceControlHandler (
             break;
 
         default:
-	    FIXME("code unknown: %d\n", DAT);
+	    WARN("code unknown: %d\n", DAT);
             activeDS.twCC = TWCC_CAPUNSUPPORTED;
             twRC = TWRC_FAILURE;
             break;
@@ -440,7 +440,7 @@ static TW_UINT16 SANE_ImageGroupHandler (
                 default:
                     twRC = TWRC_FAILURE;
                     activeDS.twCC = TWCC_CAPBADOPERATION;
-                    FIXME("unrecognized operation triplet\n");
+                    WARN("unrecognized operation triplet\n");
                     break;
             }
             break;
@@ -572,7 +572,7 @@ static TW_UINT16 SANE_ImageGroupHandler (
         default:
             twRC = TWRC_FAILURE;
             activeDS.twCC = TWCC_CAPUNSUPPORTED;
-            FIXME("unrecognized DG type %d\n", DAT);
+            WARN("unrecognized DG type %d\n", DAT);
     }
     return twRC;
 }
@@ -598,7 +598,7 @@ DS_Entry ( pTW_IDENTITY pOrigin,
             twRC = SANE_ImageGroupHandler (pOrigin,DAT,MSG,pData);
             break;
         case DG_AUDIO:
-            FIXME("Audio group of controls not implemented yet.\n");
+            WARN("Audio group of controls not implemented yet.\n");
             twRC = TWRC_FAILURE;
             activeDS.twCC = TWCC_CAPUNSUPPORTED;
             break;



More information about the wine-patches mailing list