msctf: Use FAILED instead of !SUCCEDED.
Michael Stefaniuc
mstefani at redhat.de
Tue May 19 16:46:30 CDT 2009
Found by the following short coccinelle script:
@@ expression E; @@
(
- !SUCCEEDED(E)
+ FAILED(E)
|
- !FAILED(E)
+ SUCCEEDED(E)
)
---
dlls/msctf/context.c | 2 +-
dlls/msctf/inputprocessor.c | 2 +-
dlls/msctf/tests/inputprocessor.c | 4 ++--
dlls/msctf/threadmgr.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
index 1f255c8..6a2bed6 100644
--- a/dlls/msctf/context.c
+++ b/dlls/msctf/context.c
@@ -430,7 +430,7 @@ static WINAPI HRESULT ContextSource_AdviseSink(ITfSource *iface,
es = HeapAlloc(GetProcessHeap(),0,sizeof(ContextSink));
if (!es)
return E_OUTOFMEMORY;
- if (!SUCCEEDED(IUnknown_QueryInterface(punk, riid, (LPVOID*)&es->interfaces.pITfTextEditSink)))
+ if (FAILED(IUnknown_QueryInterface(punk, riid, (LPVOID *)&es->interfaces.pITfTextEditSink)))
{
HeapFree(GetProcessHeap(),0,es);
return CONNECT_E_CANNOTCONNECT;
diff --git a/dlls/msctf/inputprocessor.c b/dlls/msctf/inputprocessor.c
index 90daa2f..a904a68 100644
--- a/dlls/msctf/inputprocessor.c
+++ b/dlls/msctf/inputprocessor.c
@@ -615,7 +615,7 @@ static WINAPI HRESULT IPPSource_AdviseSink(ITfSource *iface,
ipps = HeapAlloc(GetProcessHeap(),0,sizeof(InputProcessorProfilesSink));
if (!ipps)
return E_OUTOFMEMORY;
- if (!SUCCEEDED(IUnknown_QueryInterface(punk, riid, (LPVOID*)&ipps->interfaces.pITfLanguageProfileNotifySink)))
+ if (FAILED(IUnknown_QueryInterface(punk, riid, (LPVOID *)&ipps->interfaces.pITfLanguageProfileNotifySink)))
{
HeapFree(GetProcessHeap(),0,ipps);
return CONNECT_E_CANNOTCONNECT;
diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c
index 318149b..11e7233 100644
--- a/dlls/msctf/tests/inputprocessor.c
+++ b/dlls/msctf/tests/inputprocessor.c
@@ -1186,7 +1186,7 @@ static void test_startSession(void)
cnt = check_context_refcount(cxt3);
hr = ITfDocumentMgr_Push(g_dm, cxt3);
- ok(!SUCCEEDED(hr),"Push Succeeded\n");
+ ok(FAILED(hr),"Push Succeeded\n");
ok(check_context_refcount(cxt3) == cnt, "Ref changed\n");
cnt = check_context_refcount(cxt2);
@@ -1221,7 +1221,7 @@ static void test_startSession(void)
ITfContext_Release(cxtTest);
hr = ITfDocumentMgr_Pop(g_dm, 0);
- ok(!SUCCEEDED(hr),"Pop Succeeded\n");
+ ok(FAILED(hr),"Pop Succeeded\n");
hr = ITfDocumentMgr_GetTop(g_dm, &cxtTest);
ok(SUCCEEDED(hr),"GetTop Failed\n");
diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c
index c91e536..9b887f0 100644
--- a/dlls/msctf/threadmgr.c
+++ b/dlls/msctf/threadmgr.c
@@ -442,7 +442,7 @@ static WINAPI HRESULT ThreadMgrSource_AdviseSink(ITfSource *iface,
tms = HeapAlloc(GetProcessHeap(),0,sizeof(ThreadMgrSink));
if (!tms)
return E_OUTOFMEMORY;
- if (!SUCCEEDED(IUnknown_QueryInterface(punk, riid, (LPVOID*)&tms->interfaces.pITfThreadMgrEventSink)))
+ if (FAILED(IUnknown_QueryInterface(punk, riid, (LPVOID *)&tms->interfaces.pITfThreadMgrEventSink)))
{
HeapFree(GetProcessHeap(),0,tms);
return CONNECT_E_CANNOTCONNECT;
--
1.6.3
More information about the wine-patches
mailing list