[PATCH] wininet: lpwhr cannot be NULL (Coverity 927)

Marcus Meissner marcus at jet.franken.de
Wed May 20 02:33:21 CDT 2009


Hi,

There is just 1 caller of HTTP_OpenConnection() and its
code ensure that lpwhr is not NULL already.

So remove the superflous NULL check and de-confuse
Coverity ;)

Ciao, Marcus
---
 dlls/wininet/http.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index 212ff9f..904939a 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -3832,7 +3832,7 @@ static BOOL HTTP_OpenConnection(LPWININETHTTPREQW lpwhr)
     TRACE("-->\n");
 
 
-    if (NULL == lpwhr ||  lpwhr->hdr.htype != WH_HHTTPREQ)
+    if (lpwhr->hdr.htype != WH_HHTTPREQ)
     {
         INTERNET_SetLastError(ERROR_INVALID_PARAMETER);
         goto lend;
-- 
1.5.6



More information about the wine-patches mailing list