[1/2] comctl32/listview: Don't use uninitialized value

Nikolay Sivov bunglehead at gmail.com
Wed May 20 14:12:33 CDT 2009


This is actually a fix for regression caused by my previous
patch committed as 8f334205f921737de3b71c58f37081442c262a8d.

I've got an assert exception in a delphi test application
from bug I don't remember.

Changelog:
    - Don't use uninitialized value

>From f24a928960395aec495300e0b5bdf3375ae4a643 Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <bunglehead at gmail.com>
Date: Wed, 20 May 2009 22:13:19 +0400
Subject: Don't use uninitialized value

---
 dlls/comctl32/listview.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 7010a53..6e3509a 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -6565,7 +6565,7 @@ static INT LISTVIEW_HitTest(const LISTVIEW_INFO *infoPtr, LPLVHITTESTINFO lpht,
     lvItem.stateMask = LVIS_STATEIMAGEMASK;
     if (uView == LVS_ICON) lvItem.stateMask |= LVIS_FOCUSED;
     lvItem.iItem = iItem;
-    lvItem.iSubItem = lpht->iSubItem;
+    lvItem.iSubItem = subitem ? lpht->iSubItem : 0;
     lvItem.pszText = szDispText;
     lvItem.cchTextMax = DISP_TEXT_SIZE;
     if (!LISTVIEW_GetItemW(infoPtr, &lvItem)) return -1;
-- 
1.5.6.5







More information about the wine-patches mailing list