winhlp32: Avoid duplicate assignment in WINHELP_GetWindowInfo(). (RESEND)

Eric Pouech eric.pouech at orange.fr
Mon May 25 14:21:29 CDT 2009


Gerald Pfeifer a écrit :
> Originally sent ten days ago; looks obvious to me?
>
> Gerald
>
> ChangeLog:
> Avoid duplicate assignment in WINHELP_GetWindowInfo().
>
> diff --git a/programs/winhlp32/winhelp.c b/programs/winhlp32/winhelp.c
> index 7f74d8b..d1980e5 100644
> --- a/programs/winhlp32/winhelp.c
> +++ b/programs/winhlp32/winhelp.c
> @@ -278,7 +278,7 @@ HLPFILE_WINDOWINFO*     WINHELP_GetWindowInfo(HLPFILE* hlpfile, LPCSTR name)
>          mwi.origin.x = mwi.origin.y = mwi.size.cx = mwi.size.cy = CW_USEDEFAULT;
>          mwi.style = SW_SHOW;
>          mwi.win_style = WS_OVERLAPPEDWINDOW;
> -        mwi.sr_color = mwi.sr_color = 0xFFFFFF;
> +        mwi.sr_color = 0xFFFFFF;
>      }
>      return &mwi;
>  }
>
>
>
>
>   
fix is wrong
the second should be nr_color instead of sr_color (hence the "double" 
assignment)
A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)





More information about the wine-patches mailing list