mciwave: Fix copy&paste errors and remove superfluous log.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Mon Nov 2 07:56:38 CST 2009


Hi,

- shareable is neither supported nor implemented by waveaudio (other MCIxyz support it);
  Let mciOpen supply the same error code as MS-Windows.
- volatile dwPosition is recommended as the recorder thread callback updates it
  (sometimes I think the whole structure should be declared volatile).
- WARN after ExitThread is superfluous (and not present in most other code)
  -- should be ERR if at all.
- TRACE of wave format parameters is a duplicate and already logged a few lines earlier.
- TRUE (1) is not a valid return code in MMSYSTEM.
- INPUT/OUTPUTUNSPECIFIED is a typical example of copy&paste error.

Later I'll fix the same in the other MCIxyz libraries (mcicda, mcimidi and mciwave are very similar, mciavi is different). I plan to patch the former 3 only.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mciwave-Fix-copy-paste-errors-and-remove-superfluou.patch
Type: application/octet-stream
Size: 3202 bytes
Desc: 0002-mciwave-Fix-copy-paste-errors-and-remove-superfluou.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091102/f907b2ad/attachment.obj>


More information about the wine-patches mailing list