wininet: FTP_FtpOpenFileW: initialize dwInternalFlags

Dan Kegel dank at kegel.com
Thu Nov 5 23:45:25 CST 2009


Without this initialization, valgrind complains

 Conditional jump or move depends on uninitialised value(s)
    at  INTERNET_SendCallback (utility.c:304)
    by  WININET_Release (internet.c:192)
    by  WININET_FreeHandle (internet.c:238)
    by  InternetCloseHandle (internet.c:1114)
    by  protocol_close_connection (protocol.c:431)
    by  FtpProtocol_Terminate (ftp.c:183)
    by  ProtocolHandler_Terminate (bindprot.c:666)
    by  BindProtocol_Terminate (bindprot.c:436)
    by  InternetProtocolSink_ReportResult (binding.c:1086)
    by  report_result_proc (bindprot.c:1140)
    by  notif_wnd_proc (bindprot.c:111)
    by  ??? (library.h:159)
    by  call_window_proc (winproc.c:469)
    by  WINPROC_CallProcAtoW (winproc.c:1023)
    by  WINPROC_call_window (winproc.c:2225)
    by  DispatchMessageA (message.c:3089)
    by  test_BindToStorage (url.c:2330)
  Uninitialised value was created by a client request
    at  mark_block_uninitialized (heap.c:187)
    by  RtlAllocateHeap (heap.c:1429)
    by  FTP_FtpOpenFileW (ftp.c:1291)
    by  AsyncFtpOpenFileProc (ftp.c:1381)
    by  INTERNET_WorkerThreadFunc (internet.c:3128)

or

 Conditional jump or move depends on uninitialised value(s)
    at  INTERNET_SendCallback (utility.c:304)
    by  FTP_ReceiveRequestData (ftp.c:1188)
    by  FTP_FtpOpenFileW (ftp.c:1333)
    by  AsyncFtpOpenFileProc (ftp.c:1381)
    by  INTERNET_WorkerThreadFunc (internet.c:3128)
    by  worker_thread_proc (threadpool.c:114)
  Uninitialised value was created by a client request
    at  mark_block_uninitialized (heap.c:187)
    by  RtlAllocateHeap (heap.c:1429)
    by  FTP_FtpOpenFileW (ftp.c:1291)
    by  AsyncFtpOpenFileProc (ftp.c:1381)
    by  INTERNET_WorkerThreadFunc (internet.c:3128)

See http://kegel.com/wine/valgrind/logs/2009-11-05-09.09/vg-urlmon_url.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ftp.patch
Type: text/x-patch
Size: 493 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091105/fbf90729/attachment-0001.bin>


More information about the wine-patches mailing list