user32: fix uninitialized variable so first call to DdeGetLastError isn't undefined

Mike firesword14 at yahoo.com
Fri Nov 6 07:55:41 CST 2009


Thanks Dan,
     I wasn't sure what to expect, being my first patch.  Definitely encouraging to get it committed so fast.  I'll fix these items up.  Thanks for the feedback.

Mikey Alexander

--- On Thu, 11/5/09, Dan Kegel <dank at kegel.com> wrote:

> From: Dan Kegel <dank at kegel.com>
> Subject: user32: fix uninitialized variable so first call to DdeGetLastError  isn't undefined
> To: "wine-patches" <wine-patches at winehq.org>
> Cc: "Mikey Alexander" <firesword14 at yahoo.com>
> Date: Thursday, November 5, 2009, 7:16 PM
> Congrats to Mikey for getting his
> tests committed.  The first valgrind
> run of them,
> http://kegel.com/wine/valgrind/logs/2009-11-05-09.09/vg-shell32_progman_dde.txt
> found an uninit variable:
> 
>  Conditional jump or move depends on uninitialised
> value(s)
>     at  GetStringFromError
> (progman_dde.c:115)
>     by  GetDdeLastErrorStr
> (progman_dde.c:149)
>     by  func_progman_dde
> (progman_dde.c:535)
>   Uninitialised value was created by a client request
>     at  mark_block_uninitialized
> (heap.c:187)
>     by  RtlAllocateHeap (heap.c:1429)
>     by  WDML_Initialize (dde_misc.c:363)
>     by  DdeInitializeA (dde_misc.c:593)
>     by  func_progman_dde
> (progman_dde.c:530)
> 
> Here's the simple fix.
> (There were also a bunch of memory leaks in that log...
> Mikey, could
> you look at those?)
> - Dan
> 


      



More information about the wine-patches mailing list