[3/3] Revert "widl: A structure that contains an embedded interface ptr in an array is a BOGUS_STRUCT."

Rob Shearman robertshearman at gmail.com
Sat Nov 7 06:29:19 CST 2009


This reverts commit e4e21193c049085dffe9475c9c9bdf9ae6807401.

The IDBProperties test shows that this special case is not needed to
for these types to be marshalled correctly.
---
 tools/widl/typegen.c |   62 +-------------------------------------------------
 1 files changed, 1 insertions(+), 61 deletions(-)

While this code may get generated type format strings closer to what
MIDL generates, I don't believe it is trivial to compare large
sections of format strings with MIDL because of ordering differences
and widl's lack of optimisation in not outputting already output
types. Generating a complex struct format string instead of a pointer
struct will also cause marshalling performance to not be optimal.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: d4e3e7e3bd844405c79773c40a66c5f657501d9b.diff
Type: text/x-patch
Size: 2437 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091107/7829aaad/attachment.bin>


More information about the wine-patches mailing list