[PATCH] winspool.drv: remove useless assignments without NULL ptr check (Coverity)

Marcus Meissner marcus at jet.franken.de
Mon Nov 23 02:48:03 CST 2009


Hi,

Coverity spotted we need to check those 2 pointers for NULL ptrs too
before we assign them ...

But we assigned their values to be 0 already, so there is actually no
need to do it again.
-> remove

Ciao, Marcus
---
 dlls/winspool.drv/info.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c
index 7dac2b6..6d623d6 100644
--- a/dlls/winspool.drv/info.c
+++ b/dlls/winspool.drv/info.c
@@ -3766,8 +3766,6 @@ static BOOL WINSPOOL_EnumPrinters(DWORD dwType, LPWSTR lpszName,
         dwType &= ~PRINTER_ENUM_CONNECTIONS; /* we don't handle that */
         if (!dwType) {
             FIXME("We don't handle PRINTER_ENUM_CONNECTIONS\n");
-            *lpdwNeeded = 0;
-            *lpdwReturned = 0;
             return TRUE;
         }
 
-- 
1.5.6



More information about the wine-patches mailing list