[PATCH] reg: remove wrong and useless check (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Oct 20 02:31:15 CDT 2009


Hi,

The check should have been if (!value_name) (value_name
is later used) ... but we check for it already some lines
up and return.

So remove useless check.

Ciao, Marcus
---
 programs/reg/reg.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/programs/reg/reg.c b/programs/reg/reg.c
index a538d81..f0a8f8b 100644
--- a/programs/reg/reg.c
+++ b/programs/reg/reg.c
@@ -279,13 +279,6 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty,
         DWORD count;
         LONG rc;
 
-        if (value_name)
-        {
-            RegCloseKey(subkey);
-            reg_message(STRING_INVALID_CMDLINE);
-            return 1;
-        }
-
         rc = RegQueryInfoKeyW(subkey, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
             &maxValue, NULL, NULL, NULL);
         if (rc != ERROR_SUCCESS)
-- 
1.5.6



More information about the wine-patches mailing list