wineoss: enforce invariant about BlockAlign and nAvgBytesPerSec

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Mon Sep 14 06:16:57 CDT 2009


Hi,

It is not enough to prevent inconsistent input from entering the
internal wwo->waveFormat structure.  Dsound depends on being returned
a consistent format from wodOpen.
Therefore we modify the lpDesc->lpFormat, not just the wwo->waveFormat.Format.
(Until now, this was only done in the DIRECT_SOUND case).

This fixes bugs #12349 and #19901 -- at least for OSS.

The test 0 = wBitsPerSample is ancient code from before 1994 in multimedia/audio.c
long superseeded by the supported_Format() test.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oss-blockalign.patch
Type: application/octet-stream
Size: 3849 bytes
Desc: oss-blockalign.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20090914/d399bbdd/attachment.obj>


More information about the wine-patches mailing list