[PATCH] jscript: use debugstr_variant in the to_xyz helpers

[Reece Dunn]

Hi,

For unhandled variant types in to_number and friends, use the
debugstr_variant helper instead of printing the VT number to get a
more descriptive log message. This is useful for tracking down
unhandled conversions.

- Reece
-------------- next part --------------
From f6e3aa349087c8b2db53f254f1cc25adb166db4e Mon Sep 17 00:00:00 2001
From: Reece Dunn <msclrhd at gmail.com>
Date: Tue, 22 Sep 2009 19:53:19 +0100
Subject: [PATCH] jscript: use debugstr_variant in the to_xyz helpers

---
 dlls/jscript/jsutils.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/jscript/jsutils.c b/dlls/jscript/jsutils.c
index cef141a..9a055ae 100644
--- a/dlls/jscript/jsutils.c
+++ b/dlls/jscript/jsutils.c
@@ -255,7 +255,7 @@ HRESULT to_primitive(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, VARIANT *ret
         return throw_type_error(ctx, ei, IDS_TO_PRIMITIVE, NULL);
     }
     default:
-        FIXME("Unimplemented for vt %d\n", V_VT(v));
+        FIXME("unimplemented for %s\n", debugstr_variant(v));
         return E_NOTIMPL;
     }
 
@@ -287,7 +287,7 @@ HRESULT to_boolean(VARIANT *v, VARIANT_BOOL *b)
         *b = V_BOOL(v);
         break;
     default:
-        FIXME("unimplemented for vt %d\n", V_VT(v));
+        FIXME("unimplemented for %s\n", debugstr_variant(v));
         return E_NOTIMPL;
     }
 
@@ -432,7 +432,7 @@ HRESULT to_number(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, VARIANT *ret)
         V_I4(ret) = V_BOOL(v) ? 1 : 0;
         break;
     default:
-        FIXME("unimplemented for vt %d\n", V_VT(v));
+        FIXME("unimplemented for %s\n", debugstr_variant(v));
         return E_NOTIMPL;
     }
 
@@ -573,7 +573,7 @@ HRESULT to_string(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, BSTR *str)
         *str = SysAllocString(V_BOOL(v) ? trueW : falseW);
         break;
     default:
-        FIXME("unsupported vt %d\n", V_VT(v));
+        FIXME("unimplemented for %s\n", debugstr_variant(v));
         return E_NOTIMPL;
     }
 
@@ -614,7 +614,7 @@ HRESULT to_object(script_ctx_t *ctx, VARIANT *v, IDispatch **disp)
         *disp = (IDispatch*)_IDispatchEx_(dispex);
         break;
     default:
-        FIXME("unsupported vt %d\n", V_VT(v));
+        FIXME("unimplemented for %s\n", debugstr_variant(v));
         return E_NOTIMPL;
     }
 
-- 
1.6.0.4